romanov73/tis-2017
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Nagaytseva #5

Closed
NEkaterina wants to merge 3 commits from Nagaytseva into master
pull from: Nagaytseva
merge into: romanov73:master
Conversation 19 Commits 3 Files Changed 32 +1648
NEkaterina commented 2018-05-03 10:27:07 +04:00 (Migrated from gitlab.com)
Copy Link
No description provided.
romanov73 commented 2018-05-03 10:45:17 +04:00 (Migrated from gitlab.com)
Copy Link

зачем пустые строки?

зачем пустые строки?
romanov73 commented 2018-05-03 10:45:38 +04:00 (Migrated from gitlab.com)
Copy Link

code format

code format
romanov73 commented 2018-05-03 10:45:55 +04:00 (Migrated from gitlab.com)
Copy Link

insert empty line

insert empty line
romanov73 commented 2018-05-03 10:46:38 +04:00 (Migrated from gitlab.com)
Copy Link

что в методе checkFilterCity проверяется? из названия не ясно

что в методе `checkFilterCity` проверяется? из названия не ясно
romanov73 commented 2018-05-03 10:47:00 +04:00 (Migrated from gitlab.com)
Copy Link

magic number

magic number
romanov73 commented 2018-05-03 10:47:35 +04:00 (Migrated from gitlab.com)
Copy Link

что это за куча параметров? ))

что это за куча параметров? ))
romanov73 commented 2018-05-03 10:48:30 +04:00 (Migrated from gitlab.com)
Copy Link

page1, ..., page100 вот вообще никакого смысла в названиях

page1, ..., page100 вот вообще никакого смысла в названиях
romanov73 commented 2018-05-03 10:50:07 +04:00 (Migrated from gitlab.com)
Copy Link

объединить в одно условие

объединить в одно условие
romanov73 commented 2018-05-03 10:51:13 +04:00 (Migrated from gitlab.com)
Copy Link

так нельзя делать, на другом компе не сработает

так нельзя делать, на другом компе не сработает
NEkaterina commented 2018-05-03 19:56:52 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/4/diffs?diff_id=14086117&start_sha=022472b1f504e14429671368ac40515d39993524#195a7b0f3a36df2588bfb18dfc7e936aac3eb868_59_62)
NEkaterina commented 2018-05-03 19:56:52 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/4/diffs?diff_id=14086117&start_sha=022472b1f504e14429671368ac40515d39993524#edf953d41f8736c0e539eb85b7d43e9e19835f86_42_46)
NEkaterina commented 2018-05-03 19:56:53 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/4/diffs?diff_id=14086117&start_sha=022472b1f504e14429671368ac40515d39993524#edf953d41f8736c0e539eb85b7d43e9e19835f86_75_73)
NEkaterina commented 2018-05-03 19:56:53 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/4/diffs?diff_id=14086117&start_sha=022472b1f504e14429671368ac40515d39993524#edf953d41f8736c0e539eb85b7d43e9e19835f86_68_67)
NEkaterina commented 2018-05-03 19:56:53 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/4/diffs?diff_id=14086117&start_sha=022472b1f504e14429671368ac40515d39993524#4ed3120609da7370fc69ca6fcc9bb968fa79bdf9_39_38)
NEkaterina commented 2018-05-03 19:56:54 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/4/diffs?diff_id=14086117&start_sha=022472b1f504e14429671368ac40515d39993524#5aaeb5edee07d09b733f49d2b3936ce730f40c9c_75_69)
NEkaterina commented 2018-05-03 19:56:54 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/4/diffs?diff_id=14086117&start_sha=022472b1f504e14429671368ac40515d39993524#8ebbb47d366f532e17e375d7fb209cd4e3b76eaf_105_107)
NEkaterina commented 2018-05-03 19:56:54 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/4/diffs?diff_id=14086117&start_sha=022472b1f504e14429671368ac40515d39993524#12f1a9ccc5d6a099239852219ff688ed5a99590a_17_17)
NEkaterina commented 2018-05-03 19:56:54 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>89e35570 - cheange</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/4/diffs?diff_id=14086117&start_sha=022472b1f504e14429671368ac40515d39993524)
romanov73 commented 2018-05-07 11:15:43 +04:00 (Migrated from gitlab.com)
Copy Link

closed

closed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/tis-2017#5
No description provided.
Delete Branch "Nagaytseva"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?