romanov73/tis-2017
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Vasileva #4

Closed
nadya16 wants to merge 4 commits from Vasileva into master
pull from: Vasileva
merge into: romanov73:master
Conversation 19 Commits 4 Files Changed 36 +1673
nadya16 commented 2018-05-03 10:17:36 +04:00 (Migrated from gitlab.com)
Copy Link
No description provided.
romanov73 commented 2018-05-03 10:34:30 +04:00 (Migrated from gitlab.com)
Copy Link

какому номеру тесткейса соответствует этот метод?

какому номеру тесткейса соответствует этот метод?
romanov73 commented 2018-05-03 10:38:32 +04:00 (Migrated from gitlab.com)
Copy Link

checkFilter = проверитьФильтр
что делает метод?

checkFilter = проверитьФильтр что делает метод?
romanov73 commented 2018-05-03 10:39:14 +04:00 (Migrated from gitlab.com)
Copy Link

комментированный код не коммитим

комментированный код не коммитим
romanov73 commented 2018-05-03 10:39:38 +04:00 (Migrated from gitlab.com)
Copy Link

много пустых строк. зачем?

много пустых строк. зачем?
romanov73 commented 2018-05-03 10:42:13 +04:00 (Migrated from gitlab.com)
Copy Link

sout тормозит выполнение, в тестах либо нужно использовать логирование, либо убирать эти конструкции.
тем более в цикле

sout тормозит выполнение, в тестах либо нужно использовать логирование, либо убирать эти конструкции. тем более в цикле
romanov73 commented 2018-05-03 10:42:46 +04:00 (Migrated from gitlab.com)
Copy Link

удалить

удалить
romanov73 commented 2018-05-03 10:43:09 +04:00 (Migrated from gitlab.com)
Copy Link

check = проверка
проверка чего?

check = проверка проверка чего?
nadya16 commented 2018-05-03 12:48:44 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/3/diffs?diff_id=14062729&start_sha=78c676217f10cb3732ee3646e1dc13125a847edc#59520e11e410ae18e03bd9c80b459a5ee4129610_57_51)
nadya16 commented 2018-05-03 12:48:44 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/3/diffs?diff_id=14062729&start_sha=78c676217f10cb3732ee3646e1dc13125a847edc#5d398202275eba26db8e4779a039d0f9aa1a93b9_43_37)
nadya16 commented 2018-05-03 12:48:44 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/3/diffs?diff_id=14062729&start_sha=78c676217f10cb3732ee3646e1dc13125a847edc#d5a13d25046cc484a86f4ab4a69021772b9f25e5_73_61)
nadya16 commented 2018-05-03 12:48:45 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/3/diffs?diff_id=14062729&start_sha=78c676217f10cb3732ee3646e1dc13125a847edc#18c649c7988376533887313345be53f41dc90965_39_37)
nadya16 commented 2018-05-03 12:48:45 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/3/diffs?diff_id=14062729&start_sha=78c676217f10cb3732ee3646e1dc13125a847edc#84dcd9f0193c1fc60da69a9a6611888f7071eb1e_54_53)
nadya16 commented 2018-05-03 12:48:46 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/3/diffs?diff_id=14062729&start_sha=78c676217f10cb3732ee3646e1dc13125a847edc#84dcd9f0193c1fc60da69a9a6611888f7071eb1e_84_78)
nadya16 commented 2018-05-03 12:48:46 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/3/diffs?diff_id=14062729&start_sha=78c676217f10cb3732ee3646e1dc13125a847edc#84dcd9f0193c1fc60da69a9a6611888f7071eb1e_71_78)
nadya16 commented 2018-05-03 12:48:46 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>18ff9383 - Edit tests</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/3/diffs?diff_id=14062729&start_sha=78c676217f10cb3732ee3646e1dc13125a847edc)
romanov73 commented 2018-05-03 12:51:38 +04:00 (Migrated from gitlab.com)
Copy Link

не пойдет, такого пути может не быть

не пойдет, такого пути может не быть
nadya16 commented 2018-05-03 13:32:51 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/3/diffs?diff_id=14064664&start_sha=18ff93837105cbf0475defef15be4e94250ee5b2#0b19492bc06749b032f2e06a3dd17568e9f72178_19_19)
nadya16 commented 2018-05-03 13:33:29 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e82bdb34 - Edit download path</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/3/diffs?diff_id=14064702&start_sha=18ff93837105cbf0475defef15be4e94250ee5b2)
romanov73 commented 2018-05-07 11:13:57 +04:00 (Migrated from gitlab.com)
Copy Link

closed

closed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/tis-2017#4
No description provided.
Delete Branch "Vasileva"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?