romanov73/tis-2017
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

WIP: Zamaldinova #15

Closed
AlmiraZ wants to merge 4 commits from Zamaldinova into master
pull from: Zamaldinova
merge into: romanov73:master
Conversation 10 Commits 4 Files Changed 25 +912
AlmiraZ commented 2018-12-12 03:18:47 +04:00 (Migrated from gitlab.com)
Copy Link
No description provided.
kotenok-339 commented 2018-12-12 10:04:40 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>5a5b3ae2 - InitialCommit</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/14/diffs?diff_id=29329988&start_sha=9d8b87da1be23e664a148aba65e36464a32b606c)
romanov73 commented 2018-12-12 13:35:01 +04:00 (Migrated from gitlab.com)
Copy Link

Во всех методах данного класса отсутствует сравнение фактического результата и ожидаемого

Во всех методах данного класса отсутствует сравнение фактического результата и ожидаемого
AlmiraZ commented 2018-12-12 16:00:43 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 9eb0b72a - Update FilterByTest.java Сделала сравнение фактического результата и ожидаемого…

Compare with previous version

added 1 commit <ul><li>9eb0b72a - Update FilterByTest.java Сделала сравнение фактического результата и ожидаемого…</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/14/diffs?diff_id=29366984&start_sha=5a5b3ae2e936ef10ed3ec873dc24e18556103ab8)
romanov73 commented 2018-12-13 15:19:24 +04:00 (Migrated from gitlab.com)
Copy Link

это логика PageObject, здесь ее быть не должно

это логика PageObject, здесь ее быть не должно
romanov73 commented 2018-12-13 15:19:48 +04:00 (Migrated from gitlab.com)
Copy Link

здесь по-прежнему нет сравнения

здесь по-прежнему нет сравнения
AlmiraZ commented 2018-12-13 17:38:11 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/14/diffs?diff_id=29472906&start_sha=9eb0b72a3aec46995309db41be961359252c1f57#49c21d3f9374eb201df475b50450e25a6ac5e241_76_76)
AlmiraZ commented 2018-12-13 17:38:11 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>14862c7c - Update FilterByTest.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/14/diffs?diff_id=29472906&start_sha=9eb0b72a3aec46995309db41be961359252c1f57)
AlmiraZ commented 2018-12-13 17:40:59 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3ca6cc1a - Update FilterBy.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/14/diffs?diff_id=29473207&start_sha=14862c7ce352c096ac2c2fe33036e5dd7bc7a6eb)
romanov73 commented 2018-12-13 22:59:43 +04:00 (Migrated from gitlab.com)
Copy Link

resolved all discussions

resolved all discussions
romanov73 commented 2018-12-13 22:59:49 +04:00 (Migrated from gitlab.com)
Copy Link

closed

closed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/tis-2017#15
No description provided.
Delete Branch "Zamaldinova"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?