romanov73/tis-2017
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Rukavishnikova #14

Closed
kotenok-339 wants to merge 17 commits from Rukavishnikova into master
pull from: Rukavishnikova
merge into: romanov73:master
Conversation 34 Commits 17 Files Changed 16 +882 -2
kotenok-339 commented 2018-11-20 02:44:49 +04:00 (Migrated from gitlab.com)
Copy Link
No description provided.
kotenok-339 commented 2018-11-20 16:33:53 +04:00 (Migrated from gitlab.com)
Copy Link

changed title from {-InitialCommit-} to {+Rukavishnikova+}

changed title from **{-InitialCommit-}** to **{+Rukavishnikova+}**
romanov73 commented 2018-11-22 22:26:02 +04:00 (Migrated from gitlab.com)
Copy Link

драйвера подключаются в конфигурации, здесь этого делать не нужно

драйвера подключаются в конфигурации, здесь этого делать не нужно
romanov73 commented 2018-11-22 22:26:38 +04:00 (Migrated from gitlab.com)
Copy Link

тест еще не начался, а уже проверяем результат?

тест еще не начался, а уже проверяем результат?
romanov73 commented 2018-11-22 22:26:58 +04:00 (Migrated from gitlab.com)
Copy Link

такие инструкции выносятся в классы-хелперы

такие инструкции выносятся в классы-хелперы
romanov73 commented 2018-11-22 22:27:41 +04:00 (Migrated from gitlab.com)
Copy Link

это не проверка смены языка

это не проверка смены языка
romanov73 commented 2018-11-22 22:28:02 +04:00 (Migrated from gitlab.com)
Copy Link

это не проверка открытия фильтров

это не проверка открытия фильтров
romanov73 commented 2018-11-22 22:28:37 +04:00 (Migrated from gitlab.com)
Copy Link

не производится сравнение результатов поиска, URL не показатель

не производится сравнение результатов поиска, URL не показатель
romanov73 commented 2018-11-22 22:29:18 +04:00 (Migrated from gitlab.com)
Copy Link

то же самое, ни один тест не проверяет что от него требуется

то же самое, ни один тест не проверяет что от него требуется
romanov73 commented 2018-11-22 22:29:47 +04:00 (Migrated from gitlab.com)
Copy Link

мультимедиа не тестируем, см лекции

мультимедиа не тестируем, см лекции
romanov73 commented 2018-11-22 22:30:19 +04:00 (Migrated from gitlab.com)
Copy Link

см. замечания выше, здесь нет ни одной верной проверки

см. замечания выше, здесь нет ни одной верной проверки
romanov73 commented 2018-11-22 22:31:02 +04:00 (Migrated from gitlab.com)
Copy Link

тоже самое, проверки неверны

тоже самое, проверки неверны
kotenok-339 commented 2018-12-09 00:41:24 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>065d5906 - Update AnotherLinks.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29040973&start_sha=653dc6fd716be87d2e67204d39bc422cca5c84c3)
kotenok-339 commented 2018-12-09 00:43:45 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>72643afa - Update SortByTest.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29040999&start_sha=065d590693cb8610fa45b1c83be6fdb79911d44e)
kotenok-339 commented 2018-12-09 00:44:49 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>6c97e12b - Update SearchingTest.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041010&start_sha=72643afa789022c2bf7690720898bc1fa23d02eb)
kotenok-339 commented 2018-12-09 00:46:47 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3cff2872 - Update MainPageTest.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041037&start_sha=6c97e12bd2dd3f80a57564e3aa8c8e241bd18b36)
kotenok-339 commented 2018-12-09 00:48:37 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>26da0b49 - Update MainPageTest.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041062&start_sha=3cff2872167eefb7bb33a7ed2181f10c1e9d9fa0)
kotenok-339 commented 2018-12-09 00:49:42 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041078&start_sha=26da0b49b89a8d3664394f6af10e577d04bbecf0#32f45141c229689024d5f2692678c248f42e4924_34_34)
kotenok-339 commented 2018-12-09 00:49:42 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041078&start_sha=26da0b49b89a8d3664394f6af10e577d04bbecf0#32f45141c229689024d5f2692678c248f42e4924_44_44)
kotenok-339 commented 2018-12-09 00:49:43 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>bd0b9f54 - Update FilterByTest.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041078&start_sha=26da0b49b89a8d3664394f6af10e577d04bbecf0)
kotenok-339 commented 2018-12-09 00:50:24 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041085&start_sha=bd0b9f5479dd28293e4f05c3d427f5f1ce209e7f#b649498a73f24cdafafe4c9e8aae6da1866f581c_36_37)
kotenok-339 commented 2018-12-09 00:50:24 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 709ac331 - Update ChangeLanguageTest.java

Compare with previous version

added 1 commit <ul><li>709ac331 - Update ChangeLanguageTest.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041085&start_sha=bd0b9f5479dd28293e4f05c3d427f5f1ce209e7f)
kotenok-339 commented 2018-12-09 00:51:07 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041095&start_sha=709ac331bace0fe9f644b6930809051d700c239d#31403e14d39981a94f2478d8a6573f78c23eacbd_20_19)
kotenok-339 commented 2018-12-09 00:51:07 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041095&start_sha=709ac331bace0fe9f644b6930809051d700c239d#31403e14d39981a94f2478d8a6573f78c23eacbd_30_29)
kotenok-339 commented 2018-12-09 00:51:07 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041095&start_sha=709ac331bace0fe9f644b6930809051d700c239d#31403e14d39981a94f2478d8a6573f78c23eacbd_33_29)
kotenok-339 commented 2018-12-09 00:51:07 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>f0e42847 - Update AnotherlinksTest.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041095&start_sha=709ac331bace0fe9f644b6930809051d700c239d)
kotenok-339 commented 2018-12-09 00:54:01 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>8ab0bf13 - Update ChangeLanguages.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041130&start_sha=f0e42847a5268bcd5d89de737aca7eb7bd93dca6)
kotenok-339 commented 2018-12-09 00:55:02 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3b964d78 - Update FilterBy.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041139&start_sha=8ab0bf1374e204ec5a238e8d09e6e0eaf1934f79)
kotenok-339 commented 2018-12-09 00:57:24 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>119520f2 - Update MainPage.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041171&start_sha=3b964d787e9a1152515e0891ee39dab0de60cf9f)
kotenok-339 commented 2018-12-09 00:57:59 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>307e02ad - Update Search.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041183&start_sha=119520f2aa2b4be612ad72ed75d16a007ec13c85)
kotenok-339 commented 2018-12-09 00:58:32 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>4d3f85fa - Update SortBy.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041190&start_sha=307e02ad689576e342b88ca0fb0cafd72bd723a5)
kotenok-339 commented 2018-12-09 01:20:58 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>53546b1a - Update MultiMediaTest.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041483&start_sha=4d3f85fab9c267518173abf847ca7fee4786ecaf)
kotenok-339 commented 2018-12-09 01:21:49 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ff9d57a5 - Update MultiMedia.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041499&start_sha=53546b1ae76919a310e6416620522527012a1108)
kotenok-339 commented 2018-12-09 01:30:34 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ecb37038 - Update Context.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/13/diffs?diff_id=29041586&start_sha=ff9d57a5c69a56310af0a839dc2d08d8e7374c41)
romanov73 commented 2018-12-11 13:19:04 +04:00 (Migrated from gitlab.com)
Copy Link

closed

closed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/tis-2017#14
No description provided.
Delete Branch "Rukavishnikova"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?