romanov73/tis-2017
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Kravchenko #11

Closed
alexandrakrav wants to merge 2 commits from Kravchenko into master
pull from: Kravchenko
merge into: romanov73:master
Conversation 13 Commits 2 Files Changed 28 +1175
alexandrakrav commented 2018-10-09 23:30:52 +04:00 (Migrated from gitlab.com)
Copy Link
No description provided.
romanov73 commented 2018-10-11 13:39:19 +04:00 (Migrated from gitlab.com)
Copy Link

Нет assert'a, тест не упадет в случае проблем

Нет assert'a, тест не упадет в случае проблем
romanov73 commented 2018-10-11 13:40:36 +04:00 (Migrated from gitlab.com)
Copy Link

нет сравнения, что искомая информация найдена

нет сравнения, что искомая информация найдена
romanov73 commented 2018-10-11 13:41:19 +04:00 (Migrated from gitlab.com)
Copy Link

strSearch должен передаваться в метод, а не храниться в классе

`strSearch` должен передаваться в метод, а не храниться в классе
romanov73 commented 2018-10-11 13:44:10 +04:00 (Migrated from gitlab.com)
Copy Link

метод в таком виде не нужен, обычно более сложное ожидание делается, например ожидание отображение элемента

метод в таком виде не нужен, обычно более сложное ожидание делается, например ожидание отображение элемента
romanov73 commented 2018-10-11 13:47:51 +04:00 (Migrated from gitlab.com)
Copy Link

долгое ожидание тормозит исполнение тестов, даже если страница грузится быстро

долгое ожидание тормозит исполнение тестов, даже если страница грузится быстро
romanov73 commented 2018-10-11 13:49:40 +04:00 (Migrated from gitlab.com)
Copy Link

return b > pr;

`return b > pr`;
alexandrakrav commented 2018-10-11 20:27:37 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/10/diffs?diff_id=24936311&start_sha=181581f3bc0c8e6d75c0749439771216f5f0ba87#ec44299baf29d2a4d35f87af5e889ff4e7ffa515_35_35)
alexandrakrav commented 2018-10-11 20:27:39 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/10/diffs?diff_id=24936311&start_sha=181581f3bc0c8e6d75c0749439771216f5f0ba87#060ee4f7f1973cb4f064122f3dcc0a644f7da96a_64_62)
alexandrakrav commented 2018-10-11 20:27:40 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/10/diffs?diff_id=24936311&start_sha=181581f3bc0c8e6d75c0749439771216f5f0ba87#794bf4cbfe009da03c28537fef26620dcf11eab6_41_46)
alexandrakrav commented 2018-10-11 20:27:41 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/10/diffs?diff_id=24936311&start_sha=181581f3bc0c8e6d75c0749439771216f5f0ba87#8c1fe0c63e52b9b0df330f836ed90630731f0a43_164_167)
alexandrakrav commented 2018-10-11 20:27:41 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/tis-2017/merge_requests/10/diffs?diff_id=24936311&start_sha=181581f3bc0c8e6d75c0749439771216f5f0ba87#060ee4f7f1973cb4f064122f3dcc0a644f7da96a_79_75)
alexandrakrav commented 2018-10-11 20:27:42 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>7e349a72 - bugfix</li></ul> [Compare with previous version](https://gitlab.com/romanov73/tis-2017/merge_requests/10/diffs?diff_id=24936311&start_sha=181581f3bc0c8e6d75c0749439771216f5f0ba87)
romanov73 commented 2018-10-18 20:44:58 +04:00 (Migrated from gitlab.com)
Copy Link

closed

closed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/tis-2017#11
No description provided.
Delete Branch "Kravchenko"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?