Resolve "Сводка по ping активностей" #236

Merged
arefiev1997 merged 9 commits from 112-ping-stats into dev 5 years ago
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

Closes #112

Closes #112
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

changed milestone to %6

changed milestone to %6
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

added 22 commits

Compare with previous version

added 22 commits <ul><li>eba35924...336a16ff - 19 commits from branch <code>dev</code></li><li>482e2b35 - #112 base ping activities</li><li>a35bcfce - #112 merged with dev</li><li>e680aa30 - #112 ping activity</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/109/diffs?diff_id=43692580&start_sha=eba35924106fa4ef055276e76af6a025e8fb5352)
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

assigned to @arefiev1997

assigned to @arefiev1997
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

assigned to @romanov73 and unassigned @arefiev1997

assigned to @romanov73 and unassigned @arefiev1997
romanov73 commented 5 years ago (Migrated from gitlab.com)

Нужно вести список пингов у каждой активности свой, иначе вот эти два метода так и будут разрастаться if..else.

Добавьте отдельную абстракцию

Нужно вести список пингов у каждой активности свой, иначе вот эти два метода так и будут разрастаться if..else. Добавьте отдельную абстракцию
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/109/diffs?diff_id=43848223&start_sha=e680aa30c4798685c9c6c6f2c6ebf3c5fc846b66#3b51d12150d4a8eda5787d2abf148ecfbd8708c1_114_79)
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

resolved all discussions

resolved all discussions
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

added 40 commits

Compare with previous version

added 40 commits <ul><li>e680aa30...330ffc4d - 36 commits from branch <code>dev</code></li><li>a4052670 - merged with dev</li><li>2d230afa - #112changed mapping</li><li>3898dcf1 - #112 changed mapping</li><li>abea3c7d - #112 ping model changed</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/109/diffs?diff_id=43848223&start_sha=e680aa30c4798685c9c6c6f2c6ebf3c5fc846b66)
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

added 4 commits

  • abea3c7d...a878f8c2 - 3 commits from branch dev
  • bdb8fd8c - Merge remote-tracking branch 'origin/dev' into 112-ping-stats

Compare with previous version

added 4 commits <ul><li>abea3c7d...a878f8c2 - 3 commits from branch <code>dev</code></li><li>bdb8fd8c - Merge remote-tracking branch &#39;origin/dev&#39; into 112-ping-stats</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/109/diffs?diff_id=44208085&start_sha=abea3c7dad3a44e94fb09821c223f45bde7a23ae)
arefiev1997 commented 5 years ago (Migrated from gitlab.com)

added 39 commits

  • bdb8fd8c...624573a4 - 38 commits from branch dev
  • c0afabc3 - #112 merged with dev

Compare with previous version

added 39 commits <ul><li>bdb8fd8c...624573a4 - 38 commits from branch <code>dev</code></li><li>c0afabc3 - #112 merged with dev</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/109/diffs?diff_id=44241451&start_sha=bdb8fd8ce476c67822caedee87e9a2cd4836c0d2)
romanov73 commented 5 years ago (Migrated from gitlab.com)

merged

merged
romanov73 commented 5 years ago (Migrated from gitlab.com)

mentioned in commit 1ccec83390

mentioned in commit 1ccec8339032cef62fa6a82459bbc9e69d158440
The pull request has been merged as 1ccec83390.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b 112-ping-stats dev
git pull origin 112-ping-stats

Step 2:

Merge the changes and update on Gitea.
git checkout dev
git merge --no-ff 112-ping-stats
git push origin dev
Sign in to join this conversation.
No reviewers
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/ng-tracker#236
Loading…
There is no content yet.