romanov73
/
ng-tracker
1
0
Fork 0
Code Issues 18 Pull Requests 4 Projects Releases Wiki Activity

Labels Milestones

Resolve "Ведение списка литературы статей" #235

Merged
SemenovaMasha merged 1 commits from 127-paper-references into dev 5 years ago
Conversation 13 Commits 1 Files Changed 3
SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

Closes #127

Closes #127
SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed milestone to %2

changed milestone to %2
SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

added 11 commits

Compare with previous version

added 11 commits <ul><li>59bc0dbd...82ae42f7 - 5 commits from branch <code>dev</code></li><li>29cfadef - #127 reference model, schema</li><li>7c1b124c - #127 references tab, crud</li><li>512a805e - #127 references formatting</li><li>24a12760 - #127 autocomplete</li><li>421ed635 - Merge branch &#39;dev&#39; into 127-paper-references</li><li>01bcac26 - #127 allow nullable year</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/108/diffs?diff_id=43022229&start_sha=59bc0dbd347b9fa7d7939a039295b8f013001ebe)
SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

assigned to @romanov73

assigned to @romanov73
romanov73 commented 5 years ago (Migrated from gitlab.com)

private и нужно использовать наиболее общий тип, в данном случае List

private и нужно использовать наиболее общий тип, в данном случае List
romanov73 commented 5 years ago (Migrated from gitlab.com)

List везде

List везде
romanov73 commented 5 years ago (Migrated from gitlab.com)

вынести дублирующийся код из обоих методов в отдельный метод

вынести дублирующийся код из обоих методов в отдельный метод
SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/108/diffs?diff_id=43087602&start_sha=01bcac2680f4b0e64e5fd69b03d3679d7c0bd759#135d8cb7f6ee2635ac7cf5a98731606612783a83_6_7)
SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/108/diffs?diff_id=43087602&start_sha=01bcac2680f4b0e64e5fd69b03d3679d7c0bd759#ba182fc91b42397d920e1315d94c49a32db8b0b2_13_13)
SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

added 12 commits

  • 01bcac26...c9ecae98 - 10 commits from branch dev
  • 43e7b9fe - Merge branch 'dev' into 127-paper-references
  • 22195813 - #127 fixes

Compare with previous version

added 12 commits <ul><li>01bcac26...c9ecae98 - 10 commits from branch <code>dev</code></li><li>43e7b9fe - Merge branch &#39;dev&#39; into 127-paper-references</li><li>22195813 - #127 fixes</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/108/diffs?diff_id=43087602&start_sha=01bcac2680f4b0e64e5fd69b03d3679d7c0bd759)
romanov73 commented 5 years ago (Migrated from gitlab.com)

resolved all discussions

resolved all discussions
romanov73 commented 5 years ago (Migrated from gitlab.com)

mentioned in commit eba3592410

mentioned in commit eba35924106fa4ef055276e76af6a025e8fb5352
romanov73 commented 5 years ago (Migrated from gitlab.com)

merged

merged
The pull request has been merged as eba3592410.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b 127-paper-references dev
git pull origin 127-paper-references

Step 2:

Merge the changes and update on Gitea.
git checkout dev
git merge --no-ff 127-paper-references
git push origin dev
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
backend
   
bug
   
frontend
   
выполнить первой
   
выполняется
   
конференции
   
события
   
статьи
No Label
backend
bug
frontend
выполнить первой
выполняется
конференции
события
статьи
Milestone
Set milestone
Clear milestone
No items
No Milestone
Статьи
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/ng-tracker#235
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '127-paper-references'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes