romanov73/ng-tracker
1
0
Fork 0
Code Issues 18 Pull Requests 4 Projects Releases Wiki Activity

Resolve "Реализовать модульные тесты" #219

Merged
VladimirZarayskiy merged 1 commits from 104-module-test-conf into dev 2019-05-17 11:27:22 +04:00
Conversation 33 Commits 1 Files Changed 1 +7 -1
VladimirZarayskiy commented 2019-05-12 14:04:09 +04:00 (Migrated from gitlab.com)
Copy Link
No description provided.
VladimirZarayskiy commented 2019-05-12 14:04:24 +04:00 (Migrated from gitlab.com)
Copy Link

changed milestone to %5

changed milestone to %5
VladimirZarayskiy commented 2019-05-14 00:03:27 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>9da5fd8a - #104 shock, the first unit test works</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=41947276&start_sha=ff7f535980ed6a34695b0f36665f61d65e06cb57)
VladimirZarayskiy commented 2019-05-14 16:21:47 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>3a9fde34 - #104 setUp fields</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42027417&start_sha=9da5fd8a7a8ae3d4f8fff8aea2d5349f1fc3ca2a)
VladimirZarayskiy commented 2019-05-14 17:49:49 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a8d987b0 - #104 test copy from dto method</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42040776&start_sha=3a9fde3404bd3422dabde9a2a5459508bd043765)
VladimirZarayskiy commented 2019-05-14 17:54:41 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e6cb9914 - #104 test is member</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42041397&start_sha=a8d987b01f5e62f3a48652c248c7f55904518e00)
VladimirZarayskiy commented 2019-05-14 18:03:11 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1c5c05b5 - #104 test take part</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42042476&start_sha=e6cb991463b4a6d0eb549d6dc9418b63b5fc97e0)
VladimirZarayskiy commented 2019-05-14 18:20:25 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c88c77cd - #104 test find one dto</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42048178&start_sha=1c5c05b5e466ff364d9e335615018b03151e39a1)
VladimirZarayskiy commented 2019-05-14 18:51:33 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>11cab955 - #104 test create</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42055248&start_sha=c88c77cd7db6800f8d0df39351a0f54916ad02f2)
VladimirZarayskiy commented 2019-05-15 00:54:52 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>00c5d5f7 - #104 test refactoring</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42083097&start_sha=11cab955b4d51bbc3b11413a0e0d844b05edfb5a)
VladimirZarayskiy commented 2019-05-15 01:14:23 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>79527872 - #104 add new tests, fixes</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42084268&start_sha=00c5d5f755732ec8b22922df44ec8aa7b5e4bbd7)
VladimirZarayskiy commented 2019-05-15 01:28:32 +04:00 (Migrated from gitlab.com)
Copy Link

added 32 commits

  • 79527872...51851baa - 31 commits from branch dev
  • 1e06edfc - Merge remote-tracking branch 'remotes/origin/dev' into 104-module-test-conf

Compare with previous version

added 32 commits <ul><li>79527872...51851baa - 31 commits from branch <code>dev</code></li><li>1e06edfc - Merge remote-tracking branch &#39;remotes/origin/dev&#39; into 104-module-test-conf</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42084951&start_sha=7952787229fa31ec706ce6491ab5db8e5f72307f)
VladimirZarayskiy commented 2019-05-15 01:36:02 +04:00 (Migrated from gitlab.com)
Copy Link

assigned to @romanov73

assigned to @romanov73
VladimirZarayskiy commented 2019-05-15 01:36:03 +04:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
romanov73 commented 2019-05-16 08:14:31 +04:00 (Migrated from gitlab.com)
Copy Link

Ассерты более чем странные в тестах. Вроде начинаем тестировать одну логику а сопоставляем весь объект.

Ассерты более чем странные в тестах. Вроде начинаем тестировать одну логику а сопоставляем весь объект.
romanov73 commented 2019-05-16 08:16:12 +04:00 (Migrated from gitlab.com)
Copy Link

Вот здесь, например что проверяется? Взяли объект, отдали его в метод и ждем что он останется точно таким же. Зачем же тогда нужен этот метод?

Вот здесь, например что проверяется? Взяли объект, отдали его в метод и ждем что он останется точно таким же. Зачем же тогда нужен этот метод?
romanov73 commented 2019-05-16 08:16:26 +04:00 (Migrated from gitlab.com)
Copy Link

то же самое

то же самое
romanov73 commented 2019-05-16 08:17:41 +04:00 (Migrated from gitlab.com)
Copy Link

все параметры в константы

все параметры в константы
VladimirZarayskiy commented 2019-05-16 13:34:19 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>ce7b4c9c - #104 addDeadline, removeDeadline fixed</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42241222&start_sha=1e06edfcc050d8aa4c61a0b8db6a0be556577f85)
VladimirZarayskiy commented 2019-05-16 15:35:40 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42255556&start_sha=ce7b4c9c7a81d0752efc61a94a9216828aa5afd9#49e191f977c693511e571939230ca5865e327236_203_203)
VladimirZarayskiy commented 2019-05-16 15:35:40 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42255556&start_sha=ce7b4c9c7a81d0752efc61a94a9216828aa5afd9#49e191f977c693511e571939230ca5865e327236_209_210)
VladimirZarayskiy commented 2019-05-16 15:35:41 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c0937d72 - #104 removePaper, addPaper, takePart fixed</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42255556&start_sha=ce7b4c9c7a81d0752efc61a94a9216828aa5afd9)
VladimirZarayskiy commented 2019-05-16 15:55:34 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42257670&start_sha=c0937d721a2801efeb0b9a179ffaf9d08338f89b#49e191f977c693511e571939230ca5865e327236_142_149)
VladimirZarayskiy commented 2019-05-16 15:55:34 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42257670&start_sha=c0937d721a2801efeb0b9a179ffaf9d08338f89b#49e191f977c693511e571939230ca5865e327236_243_252)
VladimirZarayskiy commented 2019-05-16 15:55:34 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>bde9cb51 - #104 some methods fixed</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42257670&start_sha=c0937d721a2801efeb0b9a179ffaf9d08338f89b)
VladimirZarayskiy commented 2019-05-16 16:31:18 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>80de18d3 - #104 create fixed, remove update</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42261698&start_sha=bde9cb51fb20944b340792e8bb54b8d6cbec329a)
VladimirZarayskiy commented 2019-05-16 16:36:47 +04:00 (Migrated from gitlab.com)
Copy Link

всё исправил

всё исправил
VladimirZarayskiy commented 2019-05-16 17:55:39 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>52633933 - #104 remove chart example from dashboard</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42274503&start_sha=80de18d3eeca5434490107b796b92fd7d7e10010)
VladimirZarayskiy commented 2019-05-16 18:07:22 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>dc34c7bf - #104 fixed conference-row style</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42275999&start_sha=526339337935f7913070fcfb9549ee667c31d8a1)
romanov73 commented 2019-05-17 11:26:09 +04:00 (Migrated from gitlab.com)
Copy Link

Тесты по содержанию должны быть простыми (аналогично шагам в тестовых доках), поэтому всякие инициализации выносятся в отдельные методы.

Тесты по содержанию должны быть простыми (аналогично шагам в тестовых доках), поэтому всякие инициализации выносятся в отдельные методы.
romanov73 commented 2019-05-17 11:26:41 +04:00 (Migrated from gitlab.com)
Copy Link

resolved all discussions

resolved all discussions
romanov73 commented 2019-05-17 11:27:14 +04:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
romanov73 commented 2019-05-17 11:27:22 +04:00 (Migrated from gitlab.com)
Copy Link

merged

merged
romanov73 commented 2019-05-17 11:27:22 +04:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 83aba158b6

mentioned in commit 83aba158b62ddaf86c5ac29a2a9170b6d58733c2
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend

   
bug

   
frontend

   
выполнить первой

   
выполняется

   
конференции

   
события

   
статьи
No Label
backend
bug
frontend
выполнить первой
выполняется
конференции
события
статьи
Milestone
Clear milestone
No items
No Milestone
Конференции
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/ng-tracker#219
No description provided.
Delete Branch "104-module-test-conf"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?