Labels Milestones

Resolve "Реализовать модульные тесты" #219

Merged

VladimirZarayskiy merged 1 commits from 104-module-test-conf into dev 5 years ago

Conversation 33 Commits 1 Files Changed 1

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

There is no content yet.

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

changed milestone to %5

changed milestone to %5

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 9da5fd8a - #104 shock, the first unit test works

Compare with previous version

added 1 commit <ul><li>9da5fd8a - #104 shock, the first unit test works</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=41947276&start_sha=ff7f535980ed6a34695b0f36665f61d65e06cb57)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 3a9fde34 - #104 setUp fields

Compare with previous version

added 1 commit <ul><li>3a9fde34 - #104 setUp fields</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42027417&start_sha=9da5fd8a7a8ae3d4f8fff8aea2d5349f1fc3ca2a)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• a8d987b0 - #104 test copy from dto method

Compare with previous version

added 1 commit <ul><li>a8d987b0 - #104 test copy from dto method</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42040776&start_sha=3a9fde3404bd3422dabde9a2a5459508bd043765)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• e6cb9914 - #104 test is member

Compare with previous version

added 1 commit <ul><li>e6cb9914 - #104 test is member</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42041397&start_sha=a8d987b01f5e62f3a48652c248c7f55904518e00)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 1c5c05b5 - #104 test take part

Compare with previous version

added 1 commit <ul><li>1c5c05b5 - #104 test take part</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42042476&start_sha=e6cb991463b4a6d0eb549d6dc9418b63b5fc97e0)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• c88c77cd - #104 test find one dto

Compare with previous version

added 1 commit <ul><li>c88c77cd - #104 test find one dto</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42048178&start_sha=1c5c05b5e466ff364d9e335615018b03151e39a1)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 11cab955 - #104 test create

Compare with previous version

added 1 commit <ul><li>11cab955 - #104 test create</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42055248&start_sha=c88c77cd7db6800f8d0df39351a0f54916ad02f2)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 00c5d5f7 - #104 test refactoring

Compare with previous version

added 1 commit <ul><li>00c5d5f7 - #104 test refactoring</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42083097&start_sha=11cab955b4d51bbc3b11413a0e0d844b05edfb5a)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 79527872 - #104 add new tests, fixes

Compare with previous version

added 1 commit <ul><li>79527872 - #104 add new tests, fixes</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42084268&start_sha=00c5d5f755732ec8b22922df44ec8aa7b5e4bbd7)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 32 commits

• 79527872...51851baa - 31 commits from branch dev
• 1e06edfc - Merge remote-tracking branch 'remotes/origin/dev' into 104-module-test-conf

Compare with previous version

added 32 commits <ul><li>79527872...51851baa - 31 commits from branch <code>dev</code></li><li>1e06edfc - Merge remote-tracking branch &#39;remotes/origin/dev&#39; into 104-module-test-conf</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42084951&start_sha=7952787229fa31ec706ce6491ab5db8e5f72307f)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

assigned to @romanov73

assigned to @romanov73

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

unmarked as a Work In Progress

unmarked as a **Work In Progress**

romanov73 commented 5 years ago (Migrated from gitlab.com)

Ассерты более чем странные в тестах. Вроде начинаем тестировать одну логику а сопоставляем весь объект.

Ассерты более чем странные в тестах. Вроде начинаем тестировать одну логику а сопоставляем весь объект.

romanov73 commented 5 years ago (Migrated from gitlab.com)

Вот здесь, например что проверяется? Взяли объект, отдали его в метод и ждем что он останется точно таким же. Зачем же тогда нужен этот метод?

Вот здесь, например что проверяется? Взяли объект, отдали его в метод и ждем что он останется точно таким же. Зачем же тогда нужен этот метод?

romanov73 commented 5 years ago (Migrated from gitlab.com)

то же самое

то же самое

romanov73 commented 5 years ago (Migrated from gitlab.com)

все параметры в константы

все параметры в константы

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• ce7b4c9c - #104 addDeadline, removeDeadline fixed

Compare with previous version

added 1 commit <ul><li>ce7b4c9c - #104 addDeadline, removeDeadline fixed</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42241222&start_sha=1e06edfcc050d8aa4c61a0b8db6a0be556577f85)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42255556&start_sha=ce7b4c9c7a81d0752efc61a94a9216828aa5afd9#49e191f977c693511e571939230ca5865e327236_203_203)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

changed this line in version 12 of the diff

changed this line in [version 12 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42255556&start_sha=ce7b4c9c7a81d0752efc61a94a9216828aa5afd9#49e191f977c693511e571939230ca5865e327236_209_210)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• c0937d72 - #104 removePaper, addPaper, takePart fixed

Compare with previous version

added 1 commit <ul><li>c0937d72 - #104 removePaper, addPaper, takePart fixed</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42255556&start_sha=ce7b4c9c7a81d0752efc61a94a9216828aa5afd9)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42257670&start_sha=c0937d721a2801efeb0b9a179ffaf9d08338f89b#49e191f977c693511e571939230ca5865e327236_142_149)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

changed this line in version 13 of the diff

changed this line in [version 13 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42257670&start_sha=c0937d721a2801efeb0b9a179ffaf9d08338f89b#49e191f977c693511e571939230ca5865e327236_243_252)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• bde9cb51 - #104 some methods fixed

Compare with previous version

added 1 commit <ul><li>bde9cb51 - #104 some methods fixed</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42257670&start_sha=c0937d721a2801efeb0b9a179ffaf9d08338f89b)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 80de18d3 - #104 create fixed, remove update

Compare with previous version

added 1 commit <ul><li>80de18d3 - #104 create fixed, remove update</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42261698&start_sha=bde9cb51fb20944b340792e8bb54b8d6cbec329a)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

всё исправил

всё исправил

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 52633933 - #104 remove chart example from dashboard

Compare with previous version

added 1 commit <ul><li>52633933 - #104 remove chart example from dashboard</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42274503&start_sha=80de18d3eeca5434490107b796b92fd7d7e10010)

VladimirZarayskiy commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• dc34c7bf - #104 fixed conference-row style

Compare with previous version

added 1 commit <ul><li>dc34c7bf - #104 fixed conference-row style</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/92/diffs?diff_id=42275999&start_sha=526339337935f7913070fcfb9549ee667c31d8a1)

romanov73 commented 5 years ago (Migrated from gitlab.com)

Тесты по содержанию должны быть простыми (аналогично шагам в тестовых доках), поэтому всякие инициализации выносятся в отдельные методы.

Тесты по содержанию должны быть простыми (аналогично шагам в тестовых доках), поэтому всякие инициализации выносятся в отдельные методы.

romanov73 commented 5 years ago (Migrated from gitlab.com)

resolved all discussions

resolved all discussions

romanov73 commented 5 years ago (Migrated from gitlab.com)

changed the description

changed the description

romanov73 commented 5 years ago (Migrated from gitlab.com)

merged

merged

romanov73 commented 5 years ago (Migrated from gitlab.com)

mentioned in commit 83aba158b6

mentioned in commit 83aba158b62ddaf86c5ac29a2a9170b6d58733c2

The pull request has been merged as 83aba158b6.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b 104-module-test-conf dev

git pull origin 104-module-test-conf

Step 2:

Merge the changes and update on Gitea.

git checkout dev

git merge --no-ff 104-module-test-conf

git push origin dev

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels   

backend

  

bug

  

frontend

  

выполнить первой

  

выполняется

  

конференции

  

события

  

статьи

No Label

backend

bug

frontend

выполнить первой

выполняется

конференции

события

статьи

Milestone

Set milestone

Clear milestone

No items

No Milestone

Конференции

Projects

Set Project

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/ng-tracker#219

Write Preview

Loading…

Cancel

Save

There is no content yet.