romanov73/ng-tracker
1
0
Fork 0
Code Issues 18 Pull Requests 4 Projects Releases Wiki Activity

Resolve "Фильтрация участников гранта по двум новым параметрам" #204

Merged
tatyana_belousova merged 1 commits from 117-filter-users into dev 2019-05-03 09:58:21 +04:00
Conversation 21 Commits 1 Files Changed 1 +9 -12
tatyana_belousova commented 2019-04-25 15:11:06 +04:00 (Migrated from gitlab.com)
Copy Link

Closes #117

Closes #117
tatyana_belousova commented 2019-04-25 15:11:06 +04:00 (Migrated from gitlab.com)
Copy Link

changed milestone to %4

changed milestone to %4
tatyana_belousova commented 2019-04-26 00:29:26 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>51e121ae - #117 add BAK papers filter</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40420811&start_sha=88ec35faa0a241d9fde3278ce2fe835f8eb7b38f)
tatyana_belousova commented 2019-04-26 15:17:49 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>39f3c694 - #117 add scopus papers filter</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40485980&start_sha=51e121ae249325615a3f378fe61595f9c25edcb6)
tatyana_belousova commented 2019-04-26 15:22:09 +04:00 (Migrated from gitlab.com)
Copy Link

added 6 commits

  • 39f3c694...a352f561 - 5 commits from branch dev
  • 9cf002ad - Merge remote-tracking branch 'remotes/origin/dev' into 117-filter-users

Compare with previous version

added 6 commits <ul><li>39f3c694...a352f561 - 5 commits from branch <code>dev</code></li><li>9cf002ad - Merge remote-tracking branch &#39;remotes/origin/dev&#39; into 117-filter-users</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40486377&start_sha=39f3c6947925f9999e2d58ec16ff1e698b971f6c)
tatyana_belousova commented 2019-04-26 15:23:58 +04:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
tatyana_belousova commented 2019-04-26 15:27:06 +04:00 (Migrated from gitlab.com)
Copy Link

assigned to @romanov73

assigned to @romanov73
romanov73 commented 2019-05-01 00:20:19 +04:00 (Migrated from gitlab.com)
Copy Link

в коде много повторений, посмотрите как сократить

в коде много повторений, посмотрите как сократить
romanov73 commented 2019-05-01 00:22:03 +04:00 (Migrated from gitlab.com)
Copy Link
return papers.stream()
                .filter(paper -> paper.getAuthors() != null)
.flatMap(paper.getAuthors().stream())
                .collect(toList());

не поможет?

```java return papers.stream() .filter(paper -> paper.getAuthors() != null) .flatMap(paper.getAuthors().stream()) .collect(toList()); ``` не поможет?
romanov73 commented 2019-05-01 00:22:53 +04:00 (Migrated from gitlab.com)
Copy Link

почему тут старые (предыдущие) авторы?

почему тут старые (предыдущие) авторы?
romanov73 commented 2019-05-01 00:23:50 +04:00 (Migrated from gitlab.com)
Copy Link

если уже делаем специфический запрос к БД то лучше в нем и отфильтровать все, зачем лишние данные тащить в приложение?

если уже делаем специфический запрос к БД то лучше в нем и отфильтровать все, зачем лишние данные тащить в приложение?
tatyana_belousova commented 2019-05-02 21:29:21 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40978544&start_sha=9cf002ad95f57bdcebbefd7be2dd52a0f2c5db79#ce7c00d2f25de8bf7e279fb48743517d4b49f41b_212_214)
tatyana_belousova commented 2019-05-02 21:29:21 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40978544&start_sha=9cf002ad95f57bdcebbefd7be2dd52a0f2c5db79#ce7c00d2f25de8bf7e279fb48743517d4b49f41b_232_228)
tatyana_belousova commented 2019-05-02 21:29:21 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40978544&start_sha=9cf002ad95f57bdcebbefd7be2dd52a0f2c5db79#a09d2139a65a90c7adda2cba3e4bfdedeb983984_308_308)
tatyana_belousova commented 2019-05-02 21:29:22 +04:00 (Migrated from gitlab.com)
Copy Link

added 8 commits

  • 9cf002ad...a6f21771 - 2 commits from branch dev
  • 2ebd6101 - #38 add variable "files"
  • 6442a67f - #38 update view
  • a69a257f - #38 add styles
  • 1f6d15b7 - #38 create changelogs
  • c8cfde67 - Merge remote-tracking branch 'remotes/origin/dev' into 38-attach-file-grants
  • 8b333ab3 - Merge branch '38-attach-file-grants' into 117-filter-users

Compare with previous version

added 8 commits <ul><li>9cf002ad...a6f21771 - 2 commits from branch <code>dev</code></li><li>2ebd6101 - #38 add variable &quot;files&quot;</li><li>6442a67f - #38 update view</li><li>a69a257f - #38 add styles</li><li>1f6d15b7 - #38 create changelogs</li><li>c8cfde67 - Merge remote-tracking branch &#39;remotes/origin/dev&#39; into 38-attach-file-grants</li><li>8b333ab3 - Merge branch &#39;38-attach-file-grants&#39; into 117-filter-users</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40978544&start_sha=9cf002ad95f57bdcebbefd7be2dd52a0f2c5db79)
tatyana_belousova commented 2019-05-02 21:42:06 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>b334b5d7 - #117 resolve discussions</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40979804&start_sha=8b333ab3a67085226f72abe58bbbc849dd17710c)
tatyana_belousova commented 2019-05-02 21:56:52 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>de625923 - #117 resolve discussions v.2</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40981092&start_sha=b334b5d70ecda284777035e1065476f652855a18)
tatyana_belousova commented 2019-05-02 22:00:51 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0955388f - #117 fix port</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40981365&start_sha=de625923e96ba4172ac4ae047560c85fc13e12c2)
tatyana_belousova commented 2019-05-02 22:49:55 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>74d43dcd - #117 resolve last discussion</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/77/diffs?diff_id=40984630&start_sha=0955388f277095bc08017cbc1466f58b572f7f8f)
tatyana_belousova commented 2019-05-02 22:53:22 +04:00 (Migrated from gitlab.com)
Copy Link

resolved all discussions

resolved all discussions
romanov73 commented 2019-05-03 09:58:21 +04:00 (Migrated from gitlab.com)
Copy Link

merged

merged
romanov73 commented 2019-05-03 09:58:21 +04:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 68737b976f

mentioned in commit 68737b976f986f8fa4492de40e03e311f3ec5135
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend

   
bug

   
frontend

   
выполнить первой

   
выполняется

   
конференции

   
события

   
статьи
No Label
backend
bug
frontend
выполнить первой
выполняется
конференции
события
статьи
Milestone
Clear milestone
No items
No Milestone
Гранты
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/ng-tracker#204
No description provided.
Delete Branch "117-filter-users"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?