Resolve "Добавление новой задачи" #174

Merged
ashette merged 1 commits from 74-students-add-new-task into dev 5 years ago
ashette commented 5 years ago (Migrated from gitlab.com)

Closes #74, #78

Closes #74, #78
ashette commented 5 years ago (Migrated from gitlab.com)

changed milestone to %7

changed milestone to %7
ashette commented 5 years ago (Migrated from gitlab.com)

added 1 commit

Compare with previous version

added 1 commit <ul><li>9b697c6f - #74 adding models, controllers and services</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=38932466&start_sha=b9af7c20c78b058b7ecd3efd1adb7a64b763e116)
ashette commented 5 years ago (Migrated from gitlab.com)

added 1 commit

  • f019806a - #74 fixing adding and db everything added except tags

Compare with previous version

added 1 commit <ul><li>f019806a - #74 fixing adding and db everything added except tags</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39062475&start_sha=9b697c6f3f7302a4693f71ad4fed76b688b10258)
ashette commented 5 years ago (Migrated from gitlab.com)

added 1 commit

Compare with previous version

added 1 commit <ul><li>5eae7305 - #74 codestyle</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39063412&start_sha=f019806a8e2c6ff77743aa15cac41dbc1b8c0c4c)
ashette commented 5 years ago (Migrated from gitlab.com)

unmarked as a Work In Progress

unmarked as a **Work In Progress**
ashette commented 5 years ago (Migrated from gitlab.com)

assigned to @romanov73

assigned to @romanov73
romanov73 commented 5 years ago (Migrated from gitlab.com)

все тело if должно быть в фигурных скобках

все тело if должно быть в фигурных скобках
romanov73 commented 5 years ago (Migrated from gitlab.com)

если код не работает его надо убрать

если код не работает его надо убрать
romanov73 commented 5 years ago (Migrated from gitlab.com)

тоже самое

тоже самое
romanov73 commented 5 years ago (Migrated from gitlab.com)

читаем codestyle про wildcards

читаем codestyle про wildcards
romanov73 commented 5 years ago (Migrated from gitlab.com)

перед созданием тега лучше проверить, что такого еще не существует, чтобы не плодить дубликаты

перед созданием тега лучше проверить, что такого еще не существует, чтобы не плодить дубликаты
ashette commented 5 years ago (Migrated from gitlab.com)

changed the description

changed the description
ashette commented 5 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39346944&start_sha=5eae7305c4523f2c656b5b660352540cee4a7143#001aad89020ac0061c811c7225fd6732720ab49d_59_57)
ashette commented 5 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39346944&start_sha=5eae7305c4523f2c656b5b660352540cee4a7143#001aad89020ac0061c811c7225fd6732720ab49d_79_79)
ashette commented 5 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39346944&start_sha=5eae7305c4523f2c656b5b660352540cee4a7143#001aad89020ac0061c811c7225fd6732720ab49d_68_67)
ashette commented 5 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39346944&start_sha=5eae7305c4523f2c656b5b660352540cee4a7143#cf476a4094e8f74ec155c8dcec84350f740916cf_15_13)
ashette commented 5 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39346944&start_sha=5eae7305c4523f2c656b5b660352540cee4a7143#c67fe22216ac497b0d13b60937decb0db76fa799_41_42)
ashette commented 5 years ago (Migrated from gitlab.com)

added 1 commit

Compare with previous version

added 1 commit <ul><li>d6a11a59 - #74 fixing codestyle and tags</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39346944&start_sha=5eae7305c4523f2c656b5b660352540cee4a7143)
ashette commented 5 years ago (Migrated from gitlab.com)

closed

closed
ashette commented 5 years ago (Migrated from gitlab.com)

reopened

reopened
ashette commented 5 years ago (Migrated from gitlab.com)

added 1 commit

Compare with previous version

added 1 commit <ul><li>1f36e04c - #74 fully adding tags</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39351471&start_sha=d6a11a5902f469bad0df2312e8b51778239240c5)
ashette commented 5 years ago (Migrated from gitlab.com)

Исправила ошибки, добавила теги

Исправила ошибки, добавила теги
romanov73 commented 5 years ago (Migrated from gitlab.com)

нерационально с точки зрения запросов к БД, по два раза одну и ту же сущность вытаскиваем

нерационально с точки зрения запросов к БД, по два раза одну и ту же сущность вытаскиваем
ashette commented 5 years ago (Migrated from gitlab.com)

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39515020&start_sha=1f36e04cd3eec6900f82af4dac8d8505ba9571d5#c67fe22216ac497b0d13b60937decb0db76fa799_27_26)
ashette commented 5 years ago (Migrated from gitlab.com)

added 1 commit

Compare with previous version

added 1 commit <ul><li>dbd61ce8 - Update TagService.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39515020&start_sha=1f36e04cd3eec6900f82af4dac8d8505ba9571d5)
ashette commented 5 years ago (Migrated from gitlab.com)

added 1 commit

Compare with previous version

added 1 commit <ul><li>95f70f42 - Update2 TagService.java</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39518062&start_sha=dbd61ce80c9bd8459b19feebca8c176b404ec398)
ashette commented 5 years ago (Migrated from gitlab.com)

исправила

исправила
romanov73 commented 5 years ago (Migrated from gitlab.com)

added 1 commit

Compare with previous version

added 1 commit <ul><li>d81d1cf7 - #74 some code fixes</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/47/diffs?diff_id=39528158&start_sha=95f70f425a6e379db63b9a824b97e94a3c08824d)
romanov73 commented 5 years ago (Migrated from gitlab.com)

resolved all discussions

resolved all discussions
romanov73 commented 5 years ago (Migrated from gitlab.com)

enabled an automatic merge when the pipeline for d81d1cf72c succeeds

enabled an automatic merge when the pipeline for d81d1cf72c875fe619abea9fd6c8b21d6452abff succeeds
romanov73 commented 5 years ago (Migrated from gitlab.com)

canceled the automatic merge

canceled the automatic merge
romanov73 commented 5 years ago (Migrated from gitlab.com)

mentioned in commit 3facc0c26e

mentioned in commit 3facc0c26ec30cdd5bc904bced2cbe45c02a6fcb
romanov73 commented 5 years ago (Migrated from gitlab.com)

merged

merged
The pull request has been merged as 3facc0c26e.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b 74-students-add-new-task dev
git pull origin 74-students-add-new-task

Step 2:

Merge the changes and update on Gitea.
git checkout dev
git merge --no-ff 74-students-add-new-task
git push origin dev
Sign in to join this conversation.
No reviewers
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/ng-tracker#174
Loading…
There is no content yet.