Labels Milestones

Resolve "Загрузка и сохранение файлов статей" #162

Merged

SemenovaMasha merged 1 commits from 13-paper-files into dev 5 years ago

Conversation 25 Commits 1 Files Changed 4

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

Closes #13

Closes #13

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed milestone to %2

changed milestone to %2

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

assigned to @romanov73

assigned to @romanov73

romanov73 commented 5 years ago (Migrated from gitlab.com)

ознакомьтесь с codestyle
и настройте IDE, wildcards быть не должно

ознакомьтесь с [codestyle](https://gitlab.com/romanov73/ng-tracker/wikis/Codestyle) и настройте IDE, wildcards быть не должно

romanov73 commented 5 years ago (Migrated from gitlab.com)

зачем здесь массив object? лучше dto возвращать

зачем здесь массив object? лучше dto возвращать

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37158832&start_sha=3c068df201d2c35b29ec12cf80e33106a1492c0a#cdd9988e67df323c840584707c854c29c5d1130f_6_6)

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37158832&start_sha=3c068df201d2c35b29ec12cf80e33106a1492c0a#cdd9988e67df323c840584707c854c29c5d1130f_49_55)

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• c702e2ab - #13 fileDataDto instead of Object[]

Compare with previous version

added 1 commit <ul><li>c702e2ab - #13 fileDataDto instead of Object[]</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37158832&start_sha=3c068df201d2c35b29ec12cf80e33106a1492c0a)

romanov73 commented 5 years ago (Migrated from gitlab.com)

просто deleted

просто `deleted`

romanov73 commented 5 years ago (Migrated from gitlab.com)

f.isDeleteFlag() == true зачем???

`f.isDeleteFlag() == true` зачем???

romanov73 commented 5 years ago (Migrated from gitlab.com)

.isDeleteFlag() == false зачем?

`.isDeleteFlag() == false` зачем?

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37217996&start_sha=c702e2abb49a9243f5f6b3f8209b8a94931b85da#e9ae20492c0889fdd48d76c126db5b788e5f30a4_12_12)

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37217996&start_sha=c702e2abb49a9243f5f6b3f8209b8a94931b85da#a09d2139a65a90c7adda2cba3e4bfdedeb983984_107_107)

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37217996&start_sha=c702e2abb49a9243f5f6b3f8209b8a94931b85da#a09d2139a65a90c7adda2cba3e4bfdedeb983984_93_93)

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 5da9de1b - #13 rename 'deleted', move creating fileDto to service

Compare with previous version

added 1 commit <ul><li>5da9de1b - #13 rename &#39;deleted&#39;, move creating fileDto to service</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37217996&start_sha=c702e2abb49a9243f5f6b3f8209b8a94931b85da)

romanov73 commented 5 years ago (Migrated from gitlab.com)

ошибку никогда не будет видно? лучше пробросить на верхний уровень

ошибку никогда не будет видно? лучше пробросить на верхний уровень

romanov73 commented 5 years ago (Migrated from gitlab.com)

не нужно заводить отдельную переменную

не нужно заводить отдельную переменную

romanov73 commented 5 years ago (Migrated from gitlab.com)

retrurn defelete(fileRepository.findOne(fileId))

retrurn `defelete(fileRepository.findOne(fileId))`

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37236719&start_sha=5da9de1bab4d05d448bf2a37993b29fa76615f0b#8d3882ec2a4c88e5e4a88492e8de1fe6edf24073_105_104)

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37236719&start_sha=5da9de1bab4d05d448bf2a37993b29fa76615f0b#8d3882ec2a4c88e5e4a88492e8de1fe6edf24073_119_118)

SemenovaMasha commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• a0b65f34 - #13 streams refactoring

Compare with previous version

added 1 commit <ul><li>a0b65f34 - #13 streams refactoring</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37236719&start_sha=5da9de1bab4d05d448bf2a37993b29fa76615f0b)

romanov73 commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 7012c00c - #13 fix condition

Compare with previous version

added 1 commit <ul><li>7012c00c - #13 fix condition</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37238764&start_sha=a0b65f341bca680ad048b98303ad6c86dfe591ca)

romanov73 commented 5 years ago (Migrated from gitlab.com)

added 1 commit

• 482e74e1 - #13 reduce of code

Compare with previous version

added 1 commit <ul><li>482e74e1 - #13 reduce of code</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37239379&start_sha=7012c00c5fca738a99d45adc2ea4713196778203)

romanov73 commented 5 years ago (Migrated from gitlab.com)

resolved all discussions

resolved all discussions

romanov73 commented 5 years ago (Migrated from gitlab.com)

merged

merged

romanov73 commented 5 years ago (Migrated from gitlab.com)

mentioned in commit f5ce1aa269

mentioned in commit f5ce1aa269db39fbacf153b5162f1e56f0f1916a

The pull request has been merged as f5ce1aa269.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b 13-paper-files dev

git pull origin 13-paper-files

Step 2:

Merge the changes and update on Gitea.

git checkout dev

git merge --no-ff 13-paper-files

git push origin dev

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels   

backend

  

bug

  

frontend

  

выполнить первой

  

выполняется

  

конференции

  

события

  

статьи

No Label

backend

bug

frontend

выполнить первой

выполняется

конференции

события

статьи

Milestone

Set milestone

Clear milestone

No items

No Milestone

Статьи

Projects

Set Project

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/ng-tracker#162

Write Preview

Loading…

Cancel

Save

There is no content yet.