romanov73/ng-tracker
1
0
Fork 0
Code Issues 18 Pull Requests 4 Projects Releases Wiki Activity

Resolve "Загрузка и сохранение файлов статей" #162

Merged
SemenovaMasha merged 1 commits from 13-paper-files into dev 2019-03-22 14:36:10 +04:00
Conversation 25 Commits 1 Files Changed 4 +3 -12
SemenovaMasha commented 2019-03-21 13:46:14 +04:00 (Migrated from gitlab.com)
Copy Link

Closes #13

Closes #13
SemenovaMasha commented 2019-03-21 13:46:14 +04:00 (Migrated from gitlab.com)
Copy Link

changed milestone to %2

changed milestone to %2
SemenovaMasha commented 2019-03-21 13:46:49 +04:00 (Migrated from gitlab.com)
Copy Link

assigned to @romanov73

assigned to @romanov73
romanov73 commented 2019-03-21 17:17:49 +04:00 (Migrated from gitlab.com)
Copy Link

ознакомьтесь с codestyle
и настройте IDE, wildcards быть не должно

ознакомьтесь с [codestyle](https://gitlab.com/romanov73/ng-tracker/wikis/Codestyle) и настройте IDE, wildcards быть не должно
romanov73 commented 2019-03-21 17:23:39 +04:00 (Migrated from gitlab.com)
Copy Link

зачем здесь массив object? лучше dto возвращать

зачем здесь массив object? лучше dto возвращать
SemenovaMasha commented 2019-03-21 18:27:16 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37158832&start_sha=3c068df201d2c35b29ec12cf80e33106a1492c0a#cdd9988e67df323c840584707c854c29c5d1130f_6_6)
SemenovaMasha commented 2019-03-21 18:27:16 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37158832&start_sha=3c068df201d2c35b29ec12cf80e33106a1492c0a#cdd9988e67df323c840584707c854c29c5d1130f_49_55)
SemenovaMasha commented 2019-03-21 18:27:17 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c702e2ab - #13 fileDataDto instead of Object[]</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37158832&start_sha=3c068df201d2c35b29ec12cf80e33106a1492c0a)
romanov73 commented 2019-03-21 20:37:32 +04:00 (Migrated from gitlab.com)
Copy Link

просто deleted

просто `deleted`
romanov73 commented 2019-03-21 20:38:32 +04:00 (Migrated from gitlab.com)
Copy Link

f.isDeleteFlag() == true зачем???

`f.isDeleteFlag() == true` зачем???
romanov73 commented 2019-03-21 20:39:27 +04:00 (Migrated from gitlab.com)
Copy Link

.isDeleteFlag() == false зачем?

`.isDeleteFlag() == false` зачем?
SemenovaMasha commented 2019-03-22 09:33:19 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37217996&start_sha=c702e2abb49a9243f5f6b3f8209b8a94931b85da#e9ae20492c0889fdd48d76c126db5b788e5f30a4_12_12)
SemenovaMasha commented 2019-03-22 09:33:20 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37217996&start_sha=c702e2abb49a9243f5f6b3f8209b8a94931b85da#a09d2139a65a90c7adda2cba3e4bfdedeb983984_107_107)
SemenovaMasha commented 2019-03-22 09:33:20 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37217996&start_sha=c702e2abb49a9243f5f6b3f8209b8a94931b85da#a09d2139a65a90c7adda2cba3e4bfdedeb983984_93_93)
SemenovaMasha commented 2019-03-22 09:33:20 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 5da9de1b - #13 rename 'deleted', move creating fileDto to service

Compare with previous version

added 1 commit <ul><li>5da9de1b - #13 rename &#39;deleted&#39;, move creating fileDto to service</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37217996&start_sha=c702e2abb49a9243f5f6b3f8209b8a94931b85da)
romanov73 commented 2019-03-22 10:44:35 +04:00 (Migrated from gitlab.com)
Copy Link

ошибку никогда не будет видно? лучше пробросить на верхний уровень

ошибку никогда не будет видно? лучше пробросить на верхний уровень
romanov73 commented 2019-03-22 10:45:14 +04:00 (Migrated from gitlab.com)
Copy Link

не нужно заводить отдельную переменную

не нужно заводить отдельную переменную
romanov73 commented 2019-03-22 10:58:48 +04:00 (Migrated from gitlab.com)
Copy Link

retrurn defelete(fileRepository.findOne(fileId))

retrurn `defelete(fileRepository.findOne(fileId))`
SemenovaMasha commented 2019-03-22 13:23:55 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37236719&start_sha=5da9de1bab4d05d448bf2a37993b29fa76615f0b#8d3882ec2a4c88e5e4a88492e8de1fe6edf24073_105_104)
SemenovaMasha commented 2019-03-22 13:23:56 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37236719&start_sha=5da9de1bab4d05d448bf2a37993b29fa76615f0b#8d3882ec2a4c88e5e4a88492e8de1fe6edf24073_119_118)
SemenovaMasha commented 2019-03-22 13:23:56 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>a0b65f34 - #13 streams refactoring</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37236719&start_sha=5da9de1bab4d05d448bf2a37993b29fa76615f0b)
romanov73 commented 2019-03-22 13:43:00 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>7012c00c - #13 fix condition</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37238764&start_sha=a0b65f341bca680ad048b98303ad6c86dfe591ca)
romanov73 commented 2019-03-22 13:48:56 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>482e74e1 - #13 reduce of code</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/35/diffs?diff_id=37239379&start_sha=7012c00c5fca738a99d45adc2ea4713196778203)
romanov73 commented 2019-03-22 14:35:57 +04:00 (Migrated from gitlab.com)
Copy Link

resolved all discussions

resolved all discussions
romanov73 commented 2019-03-22 14:36:10 +04:00 (Migrated from gitlab.com)
Copy Link

merged

merged
romanov73 commented 2019-03-22 14:36:10 +04:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit f5ce1aa269

mentioned in commit f5ce1aa269db39fbacf153b5162f1e56f0f1916a
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend

   
bug

   
frontend

   
выполнить первой

   
выполняется

   
конференции

   
события

   
статьи
No Label
backend
bug
frontend
выполнить первой
выполняется
конференции
события
статьи
Milestone
Clear milestone
No items
No Milestone
Статьи
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/ng-tracker#162
No description provided.
Delete Branch "13-paper-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?