romanov73/ng-tracker
1
0
Fork 0
Code Issues 18 Pull Requests 4 Projects Releases Wiki Activity

Resolve "Реализовать уведомления о дедлайне статьи" #139

Merged
alefly merged 1 commits from 11-Message-about-deadlines into master 2018-10-28 01:00:44 +04:00
Conversation 20 Commits 1 Files Changed 1 +4 -1
alefly commented 2018-10-25 09:16:48 +04:00 (Migrated from gitlab.com)
Copy Link

Closes #11

Closes #11
alefly commented 2018-10-27 22:24:39 +04:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

Compare with previous version

added 2 commits <ul><li>5e7cff8a - 1 commit from branch <code>master</code></li><li>43740981 - add deadlineDate to models</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26029563&start_sha=ed2554216df0eec8b92c775f9cd00f7fba6b119f)
alefly commented 2018-10-27 22:32:45 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>61c19e5b - add deadlineSсheduler</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26029700&start_sha=43740981f2b7335ff76aa6450957bf40d6bce4e2)
romanov73 commented 2018-10-27 23:01:22 +04:00 (Migrated from gitlab.com)
Copy Link

видимо русская "с"

видимо русская "с"
romanov73 commented 2018-10-27 23:03:15 +04:00 (Migrated from gitlab.com)
Copy Link

Оба метода выглядят одинаково, за исключением одной сроки. Общую логику стоит выносить в отдельные методы, можно всего лишь добавить параметр

Оба метода выглядят одинаково, за исключением одной сроки. Общую логику стоит выносить в отдельные методы, можно всего лишь добавить параметр
romanov73 commented 2018-10-27 23:04:09 +04:00 (Migrated from gitlab.com)
Copy Link

for (Paper paper: allPapers)
далее по коду легче будет понять с каким объектом работаем

`for (Paper paper: allPapers)` далее по коду легче будет понять с каким объектом работаем
romanov73 commented 2018-10-27 23:05:51 +04:00 (Migrated from gitlab.com)
Copy Link

for (User user : paper.getAuthors())
нет смысла заводить переменную, мы коллекцию один раз используем

`for (User user : paper.getAuthors())` нет смысла заводить переменную, мы коллекцию один раз используем
romanov73 commented 2018-10-27 23:16:19 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>7388b2cb - add database column</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030283&start_sha=61c19e5b87d6919f4bdd04d4db78468a366e954c)
romanov73 commented 2018-10-27 23:25:33 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030388&start_sha=7388b2cb274a95ca878038dc72f52423775b35a6#46070568b8f15617182eadcee867850a36a7dbab_31_0)
romanov73 commented 2018-10-27 23:25:33 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030388&start_sha=7388b2cb274a95ca878038dc72f52423775b35a6#46070568b8f15617182eadcee867850a36a7dbab_37_0)
romanov73 commented 2018-10-27 23:25:33 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030388&start_sha=7388b2cb274a95ca878038dc72f52423775b35a6#46070568b8f15617182eadcee867850a36a7dbab_40_0)
romanov73 commented 2018-10-27 23:25:33 +04:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030388&start_sha=7388b2cb274a95ca878038dc72f52423775b35a6#46070568b8f15617182eadcee867850a36a7dbab_45_0)
romanov73 commented 2018-10-27 23:25:34 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • afd854e0 - - make scheduler as a service

Compare with previous version

added 1 commit <ul><li>afd854e0 - - make scheduler as a service</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030388&start_sha=7388b2cb274a95ca878038dc72f52423775b35a6)
alefly commented 2018-10-27 23:47:03 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>92f86e70 - fix</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030756&start_sha=afd854e0cb68f614bf6a945b3190693440b9fe79)
alefly commented 2018-10-27 23:50:14 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>d0f40da3 - fix</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030797&start_sha=92f86e70c9e15e43ccb091e454c44d2a709f91d1)
alefly commented 2018-10-27 23:50:51 +04:00 (Migrated from gitlab.com)
Copy Link

assigned to @romanov73

assigned to @romanov73
alefly commented 2018-10-28 00:16:42 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>450cb92d - fix</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26031150&start_sha=d0f40da30ea20be028ac5af4ba8737dea34f65f6)
alefly commented 2018-10-28 00:17:10 +04:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>d1e6e80f - fix</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26031155&start_sha=450cb92d012b0d10325a8d660aef7c38fc071577)
romanov73 commented 2018-10-28 01:00:37 +04:00 (Migrated from gitlab.com)
Copy Link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
romanov73 commented 2018-10-28 01:00:44 +04:00 (Migrated from gitlab.com)
Copy Link

merged

merged
romanov73 commented 2018-10-28 01:00:44 +04:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 5766bdadbc

mentioned in commit 5766bdadbc20577134acb3b992666bd2551543ec
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend

   
bug

   
frontend

   
выполнить первой

   
выполняется

   
конференции

   
события

   
статьи
No Label
backend
bug
frontend
выполнить первой
выполняется
конференции
события
статьи
Milestone
Clear milestone
No items
No Milestone
Статьи
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/ng-tracker#139
No description provided.
Delete Branch "11-Message-about-deadlines"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?