Labels Milestones

Resolve "Реализовать уведомления о дедлайне статьи" #139

Merged

alefly merged 1 commits from 11-Message-about-deadlines into master 6 years ago

Conversation 20 Commits 1 Files Changed 1

alefly commented 6 years ago (Migrated from gitlab.com)

Closes #11

Closes #11

alefly commented 6 years ago (Migrated from gitlab.com)

added 2 commits

• 5e7cff8a - 1 commit from branch master
• 43740981 - add deadlineDate to models

Compare with previous version

added 2 commits <ul><li>5e7cff8a - 1 commit from branch <code>master</code></li><li>43740981 - add deadlineDate to models</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26029563&start_sha=ed2554216df0eec8b92c775f9cd00f7fba6b119f)

alefly commented 6 years ago (Migrated from gitlab.com)

added 1 commit

• 61c19e5b - add deadlineSсheduler

Compare with previous version

added 1 commit <ul><li>61c19e5b - add deadlineSсheduler</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26029700&start_sha=43740981f2b7335ff76aa6450957bf40d6bce4e2)

romanov73 commented 6 years ago (Migrated from gitlab.com)

видимо русская "с"

видимо русская "с"

romanov73 commented 6 years ago (Migrated from gitlab.com)

Оба метода выглядят одинаково, за исключением одной сроки. Общую логику стоит выносить в отдельные методы, можно всего лишь добавить параметр

Оба метода выглядят одинаково, за исключением одной сроки. Общую логику стоит выносить в отдельные методы, можно всего лишь добавить параметр

romanov73 commented 6 years ago (Migrated from gitlab.com)

for (Paper paper: allPapers)
далее по коду легче будет понять с каким объектом работаем

`for (Paper paper: allPapers)` далее по коду легче будет понять с каким объектом работаем

romanov73 commented 6 years ago (Migrated from gitlab.com)

for (User user : paper.getAuthors())
нет смысла заводить переменную, мы коллекцию один раз используем

`for (User user : paper.getAuthors())` нет смысла заводить переменную, мы коллекцию один раз используем

romanov73 commented 6 years ago (Migrated from gitlab.com)

added 1 commit

• 7388b2cb - add database column

Compare with previous version

added 1 commit <ul><li>7388b2cb - add database column</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030283&start_sha=61c19e5b87d6919f4bdd04d4db78468a366e954c)

romanov73 commented 6 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030388&start_sha=7388b2cb274a95ca878038dc72f52423775b35a6#46070568b8f15617182eadcee867850a36a7dbab_31_0)

romanov73 commented 6 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030388&start_sha=7388b2cb274a95ca878038dc72f52423775b35a6#46070568b8f15617182eadcee867850a36a7dbab_37_0)

romanov73 commented 6 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030388&start_sha=7388b2cb274a95ca878038dc72f52423775b35a6#46070568b8f15617182eadcee867850a36a7dbab_40_0)

romanov73 commented 6 years ago (Migrated from gitlab.com)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030388&start_sha=7388b2cb274a95ca878038dc72f52423775b35a6#46070568b8f15617182eadcee867850a36a7dbab_45_0)

romanov73 commented 6 years ago (Migrated from gitlab.com)

added 1 commit

• afd854e0 - - make scheduler as a service

Compare with previous version

added 1 commit <ul><li>afd854e0 - - make scheduler as a service</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030388&start_sha=7388b2cb274a95ca878038dc72f52423775b35a6)

alefly commented 6 years ago (Migrated from gitlab.com)

added 1 commit

• 92f86e70 - fix

Compare with previous version

added 1 commit <ul><li>92f86e70 - fix</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030756&start_sha=afd854e0cb68f614bf6a945b3190693440b9fe79)

alefly commented 6 years ago (Migrated from gitlab.com)

added 1 commit

• d0f40da3 - fix

Compare with previous version

added 1 commit <ul><li>d0f40da3 - fix</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26030797&start_sha=92f86e70c9e15e43ccb091e454c44d2a709f91d1)

alefly commented 6 years ago (Migrated from gitlab.com)

assigned to @romanov73

assigned to @romanov73

alefly commented 6 years ago (Migrated from gitlab.com)

added 1 commit

• 450cb92d - fix

Compare with previous version

added 1 commit <ul><li>450cb92d - fix</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26031150&start_sha=d0f40da30ea20be028ac5af4ba8737dea34f65f6)

alefly commented 6 years ago (Migrated from gitlab.com)

added 1 commit

• d1e6e80f - fix

Compare with previous version

added 1 commit <ul><li>d1e6e80f - fix</li></ul> [Compare with previous version](https://gitlab.com/romanov73/ng-tracker/merge_requests/12/diffs?diff_id=26031155&start_sha=450cb92d012b0d10325a8d660aef7c38fc071577)

romanov73 commented 6 years ago (Migrated from gitlab.com)

unmarked as a Work In Progress

unmarked as a **Work In Progress**

romanov73 commented 6 years ago (Migrated from gitlab.com)

merged

merged

romanov73 commented 6 years ago (Migrated from gitlab.com)

mentioned in commit 5766bdadbc

mentioned in commit 5766bdadbc20577134acb3b992666bd2551543ec

The pull request has been merged as 5766bdadbc.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b 11-Message-about-deadlines master

git pull origin 11-Message-about-deadlines

Step 2:

Merge the changes and update on Gitea.

git checkout master

git merge --no-ff 11-Message-about-deadlines

git push origin master

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels   

backend

  

bug

  

frontend

  

выполнить первой

  

выполняется

  

конференции

  

события

  

статьи

No Label

backend

bug

frontend

выполнить первой

выполняется

конференции

события

статьи

Milestone

Set milestone

Clear milestone

No items

No Milestone

Статьи

Projects

Set Project

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: romanov73/ng-tracker#139

Write Preview

Loading…

Cancel

Save

There is no content yet.